Skip to content

Remove hardcoded error messages from test file#904

Merged
peterbae merged 2 commits intomicrosoft:devfrom
peterbae:removeHardcoded
Dec 17, 2018
Merged

Remove hardcoded error messages from test file#904
peterbae merged 2 commits intomicrosoft:devfrom
peterbae:removeHardcoded

Conversation

@peterbae
Copy link
Copy Markdown
Contributor

@peterbae peterbae commented Dec 5, 2018

Self-explanatory. Moved some error messages to the TestResources file.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 5, 2018 •
edited
Loading

Codecov Report

Merging #904 into dev will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #904      +/-   ##
============================================
- Coverage     48.79%   48.67%   -0.12%     
+ Complexity     2824     2814      -10     
============================================
  Files           118      118              
  Lines         27877    27877              
  Branches       4642     4642              
============================================
- Hits          13602    13569      -33     
- Misses        12086    12117      +31     
- Partials       2189     2191       +2
Flag Coverage Δ Complexity Δ
#JDBC42 48.2% <ø> (-0.14%) 2772 <ø> (-11)
#JDBC43 48.57% <ø> (-0.12%) 2809 <ø> (-9)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (-2.2%) 15% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.33% <0%> (-1.09%) 109% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.43% <0%> (-0.66%) 253% <0%> (-7%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-0.44%) 89% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 64.12% <0%> (-0.21%) 64% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.52% <0%> (-0.13%) 265% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.89% <0%> (-0.1%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.63% <0%> (-0.06%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02467eb...c53d490. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.4 milestone Dec 6, 2018
@peterbae peterbae merged commit 9276e40 into microsoft:dev Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+3 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@ulvii ulvii ulvii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.1.4

Development

Successfully merging this pull request may close these issues.

6 participants

@peterbae @codecov-io @rene-ye @lilgreenbird @cheenamalhotra @ulvii